[wp-meta] [Making WordPress.org] #4903: Show Github PRs on Trac
Making WordPress.org
noreply at wordpress.org
Mon Feb 24 07:00:40 UTC 2020
#4903: Show Github PRs on Trac
-------------------------+---------------------
Reporter: dd32 | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Trac | Resolution:
Keywords: |
-------------------------+---------------------
Old description:
> With Github PRs being used more often now, there's been an attempt by a
> few people to expose Github PRs within Trac, this ticket is being used
> for tracking that effort.
>
> Initially this is going to be enabled for Core trac only, and for the
> WordPress/WordPress-develop Github repo only, but has the potential to
> have multiple repo's and multiple tracs in the future if needed.
>
> Initial development of this was worked on by @andraganescu @desrosj
> @isabel_brison @noisysocks @pento @talldanwp
>
> The commits that follow this have however been rewritten heavily by
> myself to make it performant and fit the WordPress.org style.
>
> ----
>
> Task List: ( ✅Completed, ❌Not yet, ❓Pending Question)
> ✅Track PRs on Github, and show them on Trac Tickets
> ✅Add a mention to Tickets comments when a PR is opened.
> ✅Always load PRs, for authenticated and unauthenticated (Currently it
> only auto-loads for authenticated requests)
> ✅Sync PR Comments to Trac
> ❌Sync PR Comment edits to Trac
> ❌Sync PR Code Review comments to Trac
> ❌Sync PR Code Review comment edits to Trac
> ❓Should all Github PR comments trigger Trac Emails? (Note: Edits won't
> be able to, and responses to existing code review instances would be best
> done as edits too)
> ❓Should Github PR activity be piped to Trac Firehose channels to
> compensate for lack of edit emails?
New description:
With Github PRs being used more often now, there's been an attempt by a
few people to expose Github PRs within Trac, this ticket is being used for
tracking that effort.
Initially this is going to be enabled for Core trac only, and for the
WordPress/WordPress-develop Github repo only, but has the potential to
have multiple repo's and multiple tracs in the future if needed.
Initial development of this was worked on by @andraganescu @desrosj
@isabel_brison @noisysocks @pento @talldanwp
The commits that follow this have however been rewritten heavily by myself
to make it performant and fit the WordPress.org style.
----
Task List: ( ✅Completed, ❌Not yet, ❓Pending Question)
✅Track PRs on Github, and show them on Trac Tickets
✅Add a mention to Tickets comments when a PR is opened.
✅Always load PRs, for authenticated and unauthenticated (Currently it
only auto-loads for authenticated requests)
✅Sync PR Comments to Trac
❌ Switch to using a Github App OAuth Token from dd32's personal Github
token
[https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php?marks=94,96#L88
get_authorization_token()] (or change it to select a random users
token..)
❌Sync PR Comment edits to Trac
❌Sync PR Code Review comments to Trac #5053
❌Sync PR Code Review comment edits to Trac
❓Should all Github PR comments trigger Trac Emails? (Note: Edits won't be
able to, and responses to existing code review instances would be best
done as edits too)
❓Should Github PR activity be piped to Trac Firehose channels to
compensate for lack of edit emails?
--
Comment (by dd32):
See also: #5052, #5052, #5054
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/4903#comment:24>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list