[wp-meta] [Making WordPress.org] #4499: Prevent tall screenshots overflowing container

Making WordPress.org noreply at wordpress.org
Fri Feb 14 08:38:19 UTC 2020

#4499: Prevent tall screenshots overflowing container
 Reporter:  dd32             |       Owner:  SergeyBiryukov
     Type:  defect           |      Status:  accepted
 Priority:  normal           |   Milestone:
Component:  Theme Directory  |  Resolution:
 Keywords:                   |

Comment (by dingo_d):

 I've played a bit with this screen, and I'm not sure if this resize has to
 be added when the images are generated or not, but just adding
 `?resize=1200,900` to a tall image didn't seem to do much.

 I also played a bit with flex container, but that still didn't solve the
 issue of tall images staying tall when resizing (vs regular images
 shrinking down).

 So it's a bit complicated problem :S

 I thought about adding a js resize handler that would just fix these
 heights on all images, but the entire theme js code is written in
 backbone.js and I'd need to really go through it to understand it.

 My 2 cents: we should completely rewrite the entire themes theme with
 either React.js or vanilla JS. Make it look more like plugins page.

Ticket URL: <https://meta.trac.wordpress.org/ticket/4499#comment:13>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list