[wp-meta] [Making WordPress.org] #4999: Justify curl (and other) exceptions when submit plugin

Making WordPress.org noreply at wordpress.org
Mon Feb 3 00:14:19 UTC 2020

#4999: Justify curl (and other) exceptions when submit plugin
 Reporter:  123milliseconds   |       Owner:  (none)
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:  wontfix
 Keywords:                    |
Changes (by dd32):

 * status:  new => closed
 * resolution:   => wontfix


 Documenting in the code why you're not doing something the standard
 WordPress way, and instead using an alternate or more lower "raw" method
 would also fulfil the purpose here and would make it obvious to the non-
 plugins-team members who look at the source code as to why you're doing
 something different.

 If I saw a plugin using curl directly, with no comments as to why in the
 code, I'm going to assume that they just didn't know about WP_HTTP and
 need reminding/teaching/etc.

 That being said, if you're just after the `total-time` from cURL, then
 you're probably better off using `timer_start()` and `timer_end()` around
 the WP_HTTP call.. at least that way your code will work on servers
 without cURL (more than you may think).

 Given the significant number of different things that the plugins team
 reviews and rejects, I don't think listing every single possible thing for
 justification is going to be viable. If it's justifiable, it should be
 obvious from the code, like using a X.509 certificate in the request or

 If/when there's automated scanning on submission, maybe that's where it
 could be added.. But even then, to bypass the the rejection I have a
 feeling we'd require an email to the plugins team first..

 I'm closing this as `wontfix` for now, but with the intention that it can
 be re-opened later if needed by the plugins team. Discussion can continue
 while the ticket is closed.

Ticket URL: <https://meta.trac.wordpress.org/ticket/4999#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list