[wp-meta] [Making WordPress.org] #5173: Centralise all the SEO fixes
Making WordPress.org
noreply at wordpress.org
Tue Apr 28 01:29:13 UTC 2020
#5173: Centralise all the SEO fixes
-----------------------+-----------------------
Reporter: dd32 | Owner: dd32
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: General | Resolution:
Keywords: has-patch |
-----------------------+-----------------------
Comment (by dd32):
> If bbPress needs changes to help make SEO tweaks easier, let’s make them
happen! ❤️
Unfortunately it's not a simple change. I probably shouldn't have called
out bbPress like that, o2 has similar problems, it was just a frustration
point that had delayed me making this ticket for a few weeks.
There's two major pain points with bbPress, the first is that
forums/topics/replies are not queried until they're displayed, which means
that in order to output archive/noindex/etc in the header we have to
trigger the queries earlier (See
[https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
/wp-content/plugins/support-forums/inc/class-hooks.php?marks=508-518#L498
this code] but search for `// Populate bbpress()` in that file for more.
I'm 99% certain we cause everything to be queried twice when that happens
too.
The second isn't bbPress's fault, it's
[https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
/wp-content/plugins/support-forums/inc/class-hooks.php?marks=403-490#L400
the crazy amount of logic] that is being requested to noindex things
(you'll find more query triggering in there). I'm starting to think we'd
be better off noindexing all of bbpress and selectively removing it..
The first would be helped greatly if it were altering the global
`$wp_query` object rather than making it's own, but that would require a
significant change in how bbPress works, and would mean it can't be
embedded within other pages as easy, so not really an option, it's just
something we have to deal with :)
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5173#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list