[wp-meta] [Making WordPress.org] #4758: Adjust function signature of WPorg_Handbook_Walker::walk()

Making WordPress.org noreply at wordpress.org
Tue Oct 8 08:54:48 UTC 2019


#4758: Adjust function signature of WPorg_Handbook_Walker::walk()
-----------------------+---------------------
 Reporter:  jrf        |       Owner:  (none)
     Type:  defect     |      Status:  new
 Priority:  high       |   Milestone:
Component:  Handbooks  |  Resolution:
 Keywords:  has-patch  |
-----------------------+---------------------

Comment (by jrf):

 > If we change the code on .org before changing core, then we get the same
 problems and warnings.

 Not true. The change to #meta is BC-compatible with older WP versions (pre
 the core patch going in).

 > May I suggest that you simply explain the issue in detail here in this
 ticket, instead of pointing to a 3 month old ticket with 70+ comments and
 50+ patch attachments?

 Well, without repeating myself overly much, please read this, which is the
 draft dev-note and explains both the changes as well as why changing #meta
 first won't cause an issue:
 https://gist.github.com/jrfnl/23fa057e5a951ab8b6bf8709e5e5b281

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/4758#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list