[wp-meta] [Making WordPress.org] #4758: Adjust function signature of WPorg_Handbook_Walker::walk()

Making WordPress.org noreply at wordpress.org
Tue Oct 8 08:16:07 UTC 2019

#4758: Adjust function signature of WPorg_Handbook_Walker::walk()
 Reporter:  jrf        |       Owner:  (none)
     Type:  defect     |      Status:  new
 Priority:  high       |   Milestone:
Component:  Handbooks  |  Resolution:
 Keywords:  has-patch  |

Comment (by Otto42):

 Seems like you have this the wrong way around here.

 This piece is a plugin. We don't change plugins before we change core.
 This change cannot go in until core makes its changes accordingly. Now, we
 might have to break wp.org to do it, but core changes come before meta

 The other way around makes no sense, and it also makes no sense that core
 changes can be blocked by meta changes, especially ones to the handbook
 plugin, of all things.

 In addition, looking at the code change proposed, I don't really
 understand it. The syntax must be some of that newfangled PHP 7 stuff or
 something, but what is the purpose of adding `...$args` instead of just
 using `func_get_args()`? The func_get_args function isn't deprecated or
 removed. This whole thing seems like an unnecessary change that breaks
 backward compatibility for no reason or benefit.

Ticket URL: <https://meta.trac.wordpress.org/ticket/4758#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list