[wp-meta] [Making WordPress.org] #4875: Add bulk suspension and reinstating admin tool for themes

Making WordPress.org noreply at wordpress.org
Mon Nov 25 23:17:59 UTC 2019

#4875: Add bulk suspension and reinstating admin tool for themes
 Reporter:  dingo_d                             |       Owner:  (none)
     Type:  enhancement                         |      Status:  new
 Priority:  high                                |   Milestone:
Component:  Theme Directory                     |  Resolution:
 Keywords:  has-patch dev-feedback 2nd-opinion  |

Comment (by dd32):

 Thanks @dingo_d!

 There's a lot to work through here, which makes it incredibly hard to
 review, smaller chunks or even a Git commit log may have made it easier to

 At a glance through it, there's only a few things that stood out:
  - `set_transient()` shouldn't be used for data-storage, it's backed by
 memcache on wp.org and may not be retained
  - `suspend_theme_on_trac()` queries for tickets by keyword, but we
 actually have the list of tickets stored within postmeta, which is much
 more accurate than the keywords field.
  - Does a singular-set-to-suspended still trigger
 `wporg_themes_remove_wpthemescom()`? it looks like it's now only set
 through bulk suspension? Without testing it it's hard to understand what
 the new flows are.

 Other questions:
  - Is there any reason why this is an entirely new screen? Any reason why
 it couldn't have just been a post-list filter? Seems like it'd have saved
 a lot of code with either an extra column or extra row callback added.
  - What's the purpose of having suspensions that expire like this? This
 seems like some kind of penalty box setup that doesn't really belong here?
 I initially thought it was to give the "Pending Suspension, upload changes
 by x date" functionality but it doesn't appear so? It seems like you're
 dancing around the problem of bad authors without actually dealing with
 bad authors?
  - `WPorg_Themes_List_Table` contains a loooot of code that feels like
 it's probably already offered by the `WP_List_Table` - it feels like this
 is reinventing the wheel so it can be displayed on a certain screen? Is
 `WPorg_Themes_List_Table::comments_bubble()` even needed for example?
  - This seems like several changes that should've been made in small
 discreet incremental changes, Suspension notes/reasons, bulk
 suspension/reinstate, and finally the penalty box setup, and none of those
 should've really required this much code IMHO.

Ticket URL: <https://meta.trac.wordpress.org/ticket/4875#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list