[wp-meta] [Making WordPress.org] #4237: Rejected plugins show wrong last_updated date

Making WordPress.org noreply at wordpress.org
Wed May 8 00:24:00 UTC 2019


#4237: Rejected plugins show wrong last_updated date
------------------------------+-----------------------
 Reporter:  Ipstenu           |       Owner:  ck3lee
     Type:  defect            |      Status:  assigned
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:  has-patch         |
------------------------------+-----------------------
Changes (by ck3lee):

 * keywords:   => has-patch


Comment:

 Re: @Ipstenu's suggestions:
 > 1) a meta value for 'submission_date' be added
 > 2) any status change (rejected, closed, disabled, opened, etc) changes
 the 'last_updated' value


 Current state:
 * Looks like we have an existing meta value `_submitted_date` that records
 the timestamp when plugin.zip is uploaded.  So, we can use that for search
 and reports.
 * However, `_submitted_date` is not inserted when the plugin is imported
 through cli.
 * And it looks like we are also record the timestamp every time the status
 changes. Eg: `_new`, `_pending`, `_rejected`, `_approved`.
 * However, the timestamps are set to `post_modified_gmt`. And I'm not sure
 whether that is correct. See similar comments on related ticket: #3511
 `post_modified_gmt` itself does not get updated when the status changes

 Proposed changes:
 * When status changes, always update the current timestamp with `time()`
 instead of `post_modified_gmt`.
 * When status changes, always update the `last_updated` meta value with
 the current timestamp using `time()`.
 * When plugin is imported, set `_submitted_date`.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/4237#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list