[wp-meta] [Making WordPress.org] #3791: Consider bumping pre-commit checker on plugins to PHP 7.1

Making WordPress.org noreply at wordpress.org
Sun Mar 24 18:47:16 UTC 2019

#3791: Consider bumping pre-commit checker on plugins to PHP 7.1
 Reporter:  Ipstenu           |       Owner:  (none)
     Type:  defect            |      Status:  new
 Priority:  high              |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:  pending-systems   |

Comment (by Otto42):

 We have had problems with the current iteration of the php linter, insofar
 as it looks at each individual file independently.

 If a plugin includes backwards compatibility files in a way where the back
 compat checks are actually in another file, then the non compatible file,
 which normally would not be loaded in such an environment, will fail the
 lint check and thus cannot be committed.

 Example: plugin does if ! function exists, then include file. File has
 that function. Function is a back commit function that exists in PHP 7.
 File, by itself, fails the lint. But it's never loaded because the plugin
 doesn't load it in such a case.

 This is shockingly common in libraries included by plugins, so the authors
 don't know why it fails, because it's a library they didn't write.

Ticket URL: <https://meta.trac.wordpress.org/ticket/3791#comment:9>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list