[wp-meta] [Making WordPress.org] #4638: CampTix: Country Name Spelled Wrong
Making WordPress.org
noreply at wordpress.org
Tue Jul 30 17:31:46 UTC 2019
#4638: CampTix: Country Name Spelled Wrong
-------------------------------------+-----------------------
Reporter: Yuli Yang | Owner: (none)
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: WordCamp Site & Plugins | Resolution:
Keywords: |
-------------------------------------+-----------------------
Comment (by iandunn):
> It's very unlikely people will type Republic. FWIW, Singapore is
actually Republic of Singapore :) But no one thinks of that.
WFM.
> it doesn't seem to list Hong Kong
Unfortunately we've got a bunch of country lists throughout the
wordcamp.org codebase. e.g.:
`question_field_country()`
`MES_Sponsor::markup_meta_boxes()`
`WordCamp_Post_Type_Plugin::metabox_sponsor_info()`
I think we should update them all to use `wcorg_get_countries()` as the
canonical list. That uses ISO-3166, and does include Hong Kong. Then we
can update `wcorg_get_countries()` to change `Taiwan, Province of China`
to just `Taiwan`.
CampTix couldn't use that function directly, since it's distributed in the
w.org repo, but we've talked about removing it from the repo in the past,
and this might be a good time to do that. If we do, then it could use the
function. If we don't do that, we could copy/paste the canonical list into
CampTix's existing function.
It'd be good to also use Select2 on all of those fields above; related
#4303
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/4638#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list