[wp-meta] [Making WordPress.org] #4222: Use wordpress default function and escaping function.
Making WordPress.org
noreply at wordpress.org
Wed Feb 27 00:51:42 UTC 2019
#4222: Use wordpress default function and escaping function.
-----------------------------+----------------------
Reporter: BharatKambariya | Owner: (none)
Type: defect | Status: closed
Priority: normal | Milestone:
Component: General | Resolution: invalid
Keywords: has-patch |
-----------------------------+----------------------
Changes (by dd32):
* status: new => closed
* resolution: => invalid
Comment:
The use of `wp_parse_url()` isn't required here - just because WordPress
has a wrapper for it to account for bugs in older PHP, doesn't mean it
should always be used.
`get_the_title()` doesn't need to be HTML escaped here either, and may
intentionally return HTML.
For future patches, can you also please ensure that the patch file
contains the path to the file, or mention what project the patch applies
to, as we have a lot of similar files over many different themes,
thankfully this particular one had a unique filename/textdomain though.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/4222#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list