[wp-meta] [Making WordPress.org] #4380: Plugin Directory: Be more flexible with the detected current major WP version

Making WordPress.org noreply at wordpress.org
Fri Apr 12 01:36:27 UTC 2019


#4380: Plugin Directory: Be more flexible with the detected current major WP
version
------------------------------+---------------------
 Reporter:  Ipstenu           |       Owner:  dd32
     Type:  defect            |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:  fixed
 Keywords:                    |
------------------------------+---------------------
Changes (by dd32):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:7 SergeyBiryukov]:
 > The ticket was about the "has not been tested..." banner though, not the
 readme validator. That's why I asked in comment:2 :)

 Same thing :)

 The readme parser was ignoring the `5.2` value. That caused the readme
 validator to throw a warning, but also caused the plugin to have no
 `tested up to` value, which subsequently causes the banner to show up
 (stupidly IMHO, when the 'Requres at least' header was set to `5.0`).

 `Template::is_plugin_outdated()` used `version_compare()` already, so not
 a problem there

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/4380#comment:8>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list