[wp-meta] [Making WordPress.org] #3791: Consider bumping pre-commit checker on plugins to PHP 7.1

[Making WordPress.org]

#3791: Consider bumping pre-commit checker on plugins to PHP 7.1
---------------------+---------------------
 Reporter:  Ipstenu  |       Owner:  (none)
     Type:  defect   |      Status:  new
 Priority:  normal   |   Milestone:
Component:  General  |  Resolution:
 Keywords:  neso     |
---------------------+---------------------

Comment (by dd32):

 > 1) Will bumping the checker have an ADVERSE impact on plugins written
 for 5.2.4?
 Shouldn't do. When we bumped it to 7.0 that would have added some (but
 that was okay)

 Looking at the PHP 7.1/7.2 backward incompatible changes, I see nothing
 that should change linting of older code
  - http://au2.php.net/manual/en/migration71.incompatible.php
  - http://au2.php.net/manual/en/migration72.incompatible.php

 > 2) Do we have a way to see what PHP versions plugins use?
 We can run manual lookups for that kind of thing, there are roughly 40
 plugins whose `requires_php` is PHP 7.1 or 7.2.

 > 3) If 2 is yes, do more plugins use 5.2.4 or 7.1+?
 Literally thousands more plugins are marked as requiring PHP 5.0~5.2.4. I
 don't think that has any impact here.

 I see no reason why the linting for plugin commits shouldn't be increased
 to PHP 7.2 (which is what we're currently running for web nodes).

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3791#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org