[wp-meta] [Making WordPress.org] #3882: Various changes for note feedback
Making WordPress.org
noreply at wordpress.org
Tue Oct 23 11:27:31 UTC 2018
#3882: Various changes for note feedback
---------------------------+-----------------------
Reporter: keesiemeijer | Owner: (none)
Type: defect | Status: new
Priority: normal | Milestone:
Component: Developer Hub | Keywords: has-patch
---------------------------+-----------------------
I found some small bugs and improvements now that the edit feedback
feature is implemented in the wporg-developer theme.
1 - There is a potential of quicktags beeing added to the wrong element.
The feedback section has an ID of `feedback-{$comment_id}` and the
textarea of the feedback editor has an ID of `feedback-{$instance}`. As
both of these variables are numbers there is a potential of duplicate IDs.
This only affects comments with a very low IDs.
2 - When editing a note (in the front end) the link back to the note (in
the breadcrumb trail) allways shows `note 0`.
3 - Javascript improvements. Only search the DOM for comments once.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3882>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list