[wp-meta] [Making WordPress.org] #3896: Please add a 'needs-privacy-review' Workflow keyword
Making WordPress.org
noreply at wordpress.org
Thu Nov 1 06:29:31 UTC 2018
#3896: Please add a 'needs-privacy-review' Workflow keyword
------------------------------------+---------------------
Reporter: garrett-eclipse | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Trac | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Comment (by garrett-eclipse):
Replying to [comment:7 netweb]:
> @garrett-eclipse If you're going to add the `has-privacy-review` then
you'll also want to duplicate the functionality seen with similar keywords
further down the code
[https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/style/trac
/wp-trac.js#L991 here]. What this code does is acts as a toggle, if the
keyword `has-prvicacy-review` is added then the `needs-privacy-review`
keyword is removed.
I missed that thanks for the tip @netweb updated in 3896.2.diff
Replying to [comment:7 netweb]:
> > I understand this adds it to the WorkFlow Keywords. But I was
wondering about the custom report under 'Tickets Needing Feedback' found
here;
> > https://make.wordpress.org/core/reports/
>
> The reports listed on that link above come from reports generated via
this page:
> > https://core.trac.wordpress.org/report
>
> The custom keywords such as `needs-screenshots` and `needs-privacy-
review` are not supported in these base reports. And for now just as
`needs-screenshots` is not listed as a "report" on
https://make.wordpress.org/core/reports/, `needs-privacy-review` would
also not be listed, for now at least.
>
> The Privacy component maintainers can edit the
https://make.wordpress.org/core/components/privacy/ page, so adding a link
to https://core.trac.wordpress.org/query?status=!closed&keywords=~needs-
privacy-review on that page would be the way to go
Thanks for pointing me in the right direction, I agree let's leave them
off 'for now at least' until there's some traffic worthy of linking. And
then we'll get it on the component page and reports page.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3896#comment:8>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list