[wp-meta] [Making WordPress.org] #3506: Core SVN commit blocked by a pre-commit hook

[Making WordPress.org]

#3506: Core SVN commit blocked by a pre-commit hook
-----------------------------+------------------
 Reporter:  SergeyBiryukov   |       Owner:
     Type:  defect           |      Status:  new
 Priority:  normal           |   Milestone:
Component:  Version Control  |  Resolution:
 Keywords:                   |
-----------------------------+------------------

Comment (by dd32):

 I believe meta.svn is the only repo which currently uses PHP7 linting,
 develop.svn should therefor be linting against PHP 5.6 or lower.

 > Seems like the pre-commit hook should be adjusted to allow PHP7 syntax.
 If someone unintentionally makes a PHP7-specific commit to core, Travis
 failures on older PHP versions would let us know.

 I'm inclined to agree here. Travis catches all sorts of PHP 5.2-related
 things at least once every few months - usually it's by using a function
 that doesn't exist which the linting doesn't catch.
 Using PHP7 linting shouldn't be an issue here, it'll catch malformed
 commits before they happen, won't prevent PHP7 syntaxes being used
 incorrectly, but as long as Tests are covering that part of code it should
 be fine.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3506#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org