[wp-meta] [Making WordPress.org] #2931: Plugin Directory: Incorrect parsing of code blocks

[Making WordPress.org]

#2931: Plugin Directory: Incorrect parsing of code blocks
------------------------------+-----------------------
 Reporter:  SergeyBiryukov    |       Owner:  dd32
     Type:  defect            |      Status:  accepted
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:  needs-patch       |
------------------------------+-----------------------
Changes (by dd32):

 * keywords:  2nd-opinion needs-patch => needs-patch
 * owner:  (none) => dd32
 * status:  new => accepted


Comment:

 Okay so after a lot of debugging, it looks like this is a combination of
 bugs both in our readme parser, but also in the
 [https://github.com/michelf/php-markdown markdown parser].

 The markdown parser isn't correctly handling this example:
 {{{
     #wpwrap {
         testing;
     }
 }}}
 It seems that any code block (A line starting with 4 spaces, which we
 convert {{{`...`}}} to) starting with `#` is being interpreted as a
 markdown header instead of a code block start.

 I've tested version 1.8 of the library (We're using 1.6) and it doesn't
 seem to fix it, but it doesn't make it worse.
 It looks like we can work around it on our end by not relying upon the
 libraries code block functionality, and instead rolling out own for
 {{{`...`}}}.

 Got a fair bit more testing to do though.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/2931#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org