[wp-meta] [Making WordPress.org] #2847: allow filtering of @since tax archive by the type of change

Making WordPress.org noreply at wordpress.org
Sun Jul 22 14:47:21 UTC 2018


#2847: allow filtering of @since tax archive by the type of change
--------------------------------------------------+---------------------
 Reporter:  pbiron                                |       Owner:  (none)
     Type:  enhancement                           |      Status:  new
 Priority:  normal                                |   Milestone:
Component:  Developer Hub                         |  Resolution:
 Keywords:  has-patch dev-feedback needs-refresh  |
--------------------------------------------------+---------------------
Changes (by keesiemeijer):

 * keywords:  has-patch dev-feedback => has-patch dev-feedback needs-refresh


Comment:

 @pbiron Is patch [attachment:"2847.2.diff"] correct? I get `patch does not
 apply` while the first one does apply.

 With the first patch I get a PHP warning: `Warning: Parameter 2 to
 DevHub\since_change_type_filter() expected to be a reference, value
 given`.

 You don't need to pass the query by reference in the `posts_pre_query`
 callback function (`since_change_type_filter`)

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/2847#comment:10>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list