[wp-meta] [Making WordPress.org] #3713: GlotPress negative counts

[Making WordPress.org]

#3713: GlotPress negative counts
--------------------------------------+-----------------------
 Reporter:  GaryJ                     |       Owner:  obenland
     Type:  defect                    |      Status:  reopened
 Priority:  normal                    |   Milestone:
Component:  Translate Site & Plugins  |  Resolution:
 Keywords:                            |
--------------------------------------+-----------------------
Changes (by GaryJ):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I don't deserve props for anything here!

 While this fixes the symptom, is there any underlying cause that needs
 addressing? i.e. why is `current_count` somehow ending up more than
 `all_count` in the first place?

 My suspicion is that it comes from a situation like this:
  - someone submits a string.
  - they then realise they made a mistake, and so submits a replacement
 string. There are now two strings Waiting.
  - a PTE/GTE comes along, and bulk approves all the strings (without
 appreciating that they are not all for unique original strings).

 If the strings had been approved one by one, then I think there would be
 warnings when trying to approve the second submission. However, there's no
 such visual warning for bulk approvals, so there may not be the same
 checks going on, or at least the counts logic isn't taking into
 consideration that bulk approving 100 strings may not result in 100
 approved strings, like when the situation above occurs, for instance.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3713#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org