[wp-meta] [Making WordPress.org] #3375: The schedule shortcode is echoeing an extra "1"

[Making WordPress.org]

#3375: The schedule shortcode is echoeing an extra "1"
-------------------------------------+-----------------
 Reporter:  imath                    |      Owner:
     Type:  defect                   |     Status:  new
 Priority:  normal                   |  Milestone:
Component:  WordCamp Site & Plugins  |   Keywords:
-------------------------------------+-----------------
 Although the favourite schedule email feature is
 [https://meta.trac.wordpress.org/browser/sites/trunk/wordcamp.org/public_html
 /wp-content/plugins/wc-post-types/inc/favorite-schedule-
 shortcode.php?rev=6268#L365 disabled by default] as
 `email_fav_sessions_disabled()` should prevent the favorite form to be
 displayed, the form is actually displayed and an extra "1" comes with it.
 See our [https://2018.paris.wordcamp.org/programme/ WordCamp's schedule]
 (above "Les Ateliers")

 PS: i've used a css rule to hide the form and the stars

 After looking at the code we think the problem is at line
 [https://meta.trac.wordpress.org/browser/sites/trunk/wordcamp.org/public_html
 /wp-content/plugins/wc-post-types/wc-post-types.php?rev=6268#L755 755] of
 /wc-post-types/wc-post-types.php.

 Instead of `ob_end_flush()` We suggest to use :


 {{{
 $email_form = ob_get_contents();
 ob_end_clean();
 }}}

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3375>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org