[wp-meta] [Making WordPress.org] #3485: HelpHub: Support theme update and associated plugin

Making WordPress.org noreply at wordpress.org
Sun Feb 25 17:35:44 UTC 2018

#3485: HelpHub: Support theme update and associated plugin
 Reporter:  Clorith      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:
Component:  Support Hub  |  Resolution:
 Keywords:  has-patch    |

Comment (by ocean90):

 Some quick feedback:

 * It's look like there are a few theme files with code styling changes.
 Those should be removed from the patch to keep it clean.
 * `dirname( __FILE__ )` => `__DIR__`
 * `support-helphub/inc/helphub-front-page-blocks/helphub-front-page-
 blocks.php` shouldn't have a plugin header.
 * `/support-helphub/inc/helphub-front-page-blocks/includes/class-support-
 helphub-front-page-blocks-widget.php` shouldn't have the PhpStorm header.
 * No need for `helphub-post-types/index.php`.
 * `support-helphub/inc/helphub-post-types/readme.txt` can be removed. Also
 the plugin/file headers since it's no longer its own plugin.
 * Do we really need `jQuery UI CSS Framework 1.12.1`?

Ticket URL: <https://meta.trac.wordpress.org/ticket/3485#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list