[wp-meta] [Making WordPress.org] #3769: Detection mechanism for theme support incorrectly rejecting theme

Making WordPress.org noreply at wordpress.org
Fri Aug 17 12:36:12 UTC 2018


#3769: Detection mechanism for theme support incorrectly rejecting theme
-----------------------------+----------------------
 Reporter:  flixos90         |       Owner:  (none)
     Type:  defect           |      Status:  closed
 Priority:  normal           |   Milestone:
Component:  Theme Directory  |  Resolution:  invalid
 Keywords:                   |
-----------------------------+----------------------
Changes (by Otto42):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 The check obviously cannot be perfect and detect all possible ways of
 doing things. Nor should it need to be so complex that it can literally
 read and understand code like a human being would do.

 The truth is that there is no advantage to doing this code your way, in a
 loop, vs. simply calling the code the normal way. Your code here makes
 things more complicated for no real reason.

 For that reason, I'm going to say no to this request, and ask that you
 simplify your theme. While we can't make the checks perfect and capable of
 understanding your code, we can make the themes simpler and easier to use
 and modify. Code should be simple, and understandable, and self-
 documenting. These are basic principles that hold for all good code.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3769#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list