[wp-meta] [Making WordPress.org] #3752: Sponsor logos in the Sponsors widget get removed by ad blockers

Making WordPress.org noreply at wordpress.org
Wed Aug 8 00:04:54 UTC 2018


#3752: Sponsor logos in the Sponsors widget get removed by ad blockers
----------------------------------+----------------------------------------
 Reporter:  coreymckrill          |      Owner:  (none)
     Type:  defect                |     Status:  new
 Priority:  low                   |  Milestone:
Component:  WordCamp Site &       |   Keywords:  needs-patch good-first-bug
  Plugins                         |
----------------------------------+----------------------------------------
 Some browser addon-based ad blockers, such as uBlock Origin, have a rule
 that hides elements with the `.sponsor-logo` class. The Sponsors widget in
 the `wc-post-types` plugin uses this class when displaying a list or grid
 of sponsors, which can result in an empty-looking widget. Here are a
 couple of examples:

 [[Image(https://cl.ly/0h0Y0m1V1Q07)]]

 [[Image(https://cl.ly/103S0a2E1b1d)]]

 The tricky part is, a lot of existing camps already have styles in their
 stylesheet for `.sponsor-logo` and other sponsor related elements, so
 changing the class name would potentially break the layout for a lot of
 WordCamp sites. Also, other elements that are rendered by the Sponsors
 widget and also in the `[sponsors]` shortcode use classes that begin with
 the `sponsor-` prefix, so even if `sponsor-logo` is addressed, there could
 be problems with future ad blocking rules.

 This will probably require conditionally changing all instances of the
 prefix, and setting a feature flag and using `wcorg_skip_feature()` to
 determine whether to use the old prefix or the new one.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3752>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list