[wp-meta] [Making WordPress.org] #3526: Fix any brokenness in Trac 1.2.2
Making WordPress.org
noreply at wordpress.org
Wed Apr 11 02:38:53 UTC 2018
#3526: Fix any brokenness in Trac 1.2.2
--------------------+---------------------
Reporter: dd32 | Owner: (none)
Type: task | Status: new
Priority: normal | Milestone:
Component: Trac | Resolution:
Keywords: |
--------------------+---------------------
Comment (by dd32):
Replying to [comment:26 ocean90]:
> In [changeset:"7078" 7078]:
> {{{
> #!CommitTicketReference repository="" revision="7078"
> Trac: Append a version string to Trac's JavaScript/CSS files hosted on
the w.org CDN.
>
> For testing purposes limited to meta.trac for now.
>
> See #3526.
> }}}
@ocean90 It seems like this unfortunately doesn't apply to the dynamic
stylesheet URI's when included by
{{{
<script>jQuery.loadStyleSheet("https://s.w.org/style/trac/common/css/trac.css",
"text/css");</script>
}}}
Causes both of these to be included:
- https://s.w.org/style/trac/common/css/trac.css?v=94
- https://s.w.org/style/trac/common/css/trac.css (on preview)
I guess there's two options:
1. Override the custom `$.fn.loadStyleSheet` to suffix the param (Which
can be extracted from one of the existing stylesheets)
2. Change the `py:match` to also match on
`<script>jQuery.loadStyleSheet(` (and the script version too) and alter
the URI in there?
#1 shouldn't be too hard to achieve in `wp-trac.js`, but I'm curious if #2
would be cleaner and longer-lasting?
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3526#comment:27>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list