[wp-meta] [Making WordPress.org] #3545: WP15 Theme: Language switcher doesn't get fixed when scrolling
Making WordPress.org
noreply at wordpress.org
Wed Apr 4 20:40:47 UTC 2018
#3545: WP15 Theme: Language switcher doesn't get fixed when scrolling
-------------------------+---------------------
Reporter: ChantalC | Owner: (none)
Type: defect | Status: new
Priority: normal | Milestone:
Component: General | Resolution:
Keywords: wp15, theme |
-------------------------+---------------------
Comment (by mcsf):
> I mean, the least hassle would be letting the switcher disappear. Is
that a viable option?
My two cents as someone of a different mothertongue is that it's less
about the switcher not being always available, and more that it disappears
unexpectedly ("I thought there was a thingy to change the language?")
> The first one requires overriding the parent theme's template-
parts/navigation/navigation-top.php so that it includes the language
switcher template tag, plus a reworking of the CSS grid.
I'm not familiar with this domain, but is the parent theme
`twentyseventeen`? Because, if so, changing it doesn't sound like the best
idea. Or is the parent some other niche theme with less inertia that I may
have missed?
Approach two seems viable. A drive-by suggestion, if you'd like to avoid
duplicating the element-fixing logic from the parent, is to use something
like `MutationObserver` to react to changes to `.navigation-top`'s
classes, synchronizing with the local switcher.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3545#comment:10>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list