[wp-meta] [Making WordPress.org] #3545: WP15 Theme: Language switcher doesn't get fixed when scrolling

Making WordPress.org noreply at wordpress.org
Wed Apr 4 16:37:16 UTC 2018

#3545: WP15 Theme: Language switcher doesn't get fixed when scrolling
 Reporter:  ChantalC     |       Owner:  (none)
     Type:  defect       |      Status:  new
 Priority:  normal       |   Milestone:
Component:  General      |  Resolution:
 Keywords:  wp15, theme  |

Comment (by coreymckrill):

 Replying to [comment:5 Mel Choyce]:
 > > Move the language picker inside the nav bar, and then redo the CSS
 Grid styles to accommodate that.
 > > Recreate the JS and CSS from the parent theme to work with the
 additional language picker element.
 > What's the difference between these two options?

 The first one requires overriding the parent theme's '''template-
 parts/navigation/navigation-top.php''' so that it includes the language
 switcher template tag, plus a reworking of the CSS grid.

 The second one leaves the language switcher template tag where it is in
 the child theme's '''header.php''' file, but would potentially require
 duplicating some of the parent theme's JS to add a new class to the
 switcher's container when the viewport scrolls down past the header.

Ticket URL: <https://meta.trac.wordpress.org/ticket/3545#comment:6>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list