[wp-meta] [Making WordPress.org] #3211: Cannot redeclare function as JetPack uses that function name already

Making WordPress.org noreply at wordpress.org
Thu Oct 19 10:56:49 UTC 2017


#3211: Cannot redeclare function as JetPack uses that function name already
--------------------------+------------------
 Reporter:  casiepa       |       Owner:
     Type:  defect        |      Status:  new
 Priority:  normal        |   Milestone:
Component:  WordPress.tv  |  Resolution:
 Keywords:                |
--------------------------+------------------

Comment (by SergeyBiryukov):

 That file only exists in [https://github.com/WordPress/meta-
 environment/blob/master/wordpresstv.dev/provision/sandbox-
 functionality.php Meta Environment repo on GitHub], so perhaps it should
 have been reported there, but I guess here is fine as well :)

 The function is there as a fallback so it could be used in `the_video()`
 and `the_video_image()` in [source:sites/trunk/wordpress.tv/public_html
 /wp-content/themes/wptv2/functions.php?rev=5015&marks=486,550#L474 wptv2
 theme] without Jetpack, so changing the name doesn't make much sense.

 I think it should be moved to the theme itself, with a `function_exists()`
 check (a check alone wouldn't be enough, as `mu-plugins` load earlier than
 regular plugins).

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3211#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list