[wp-meta] [Making WordPress.org] #2587: Update browse-happy

[Making WordPress.org]

#2587: Update browse-happy
------------------------------+------------------
 Reporter:  azaozz            |       Owner:
     Type:  defect            |      Status:  new
 Priority:  normal            |   Milestone:
Component:  API               |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch commit


Comment:

 In [attachment:2587.patch]
 * Bump the Internet Explorer version considered secure from 8 to 11.
 * Convert the custom `tests.php` file to PHPUnit tests, which appears to
 be the preferred way in newer projects like the
 [source:sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-
 directory/tests Plugin Directory plugin].
 * Add a test for insecure browsers.

 Note that there are currently 5 known failures, same as in the current
 `tests.php` file, that should be addressed in another ticket:
 {{{
 There were 5 failures:

 1) Tests_Browse_Happy::test_browsehappy_parse_user_agent with data set #34
 ('Mozilla/5.0 (iPad; U; CPU iPh....21.10', 'iPad Safari 4.0.4')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'iPad Safari 4.0.4'
 +'iPad iPad 4.0.4'

 S:\home\wordpress.dev\meta\sites\trunk\api.wordpress.org\public_html\core
 \browse-happy\1.0\tests\phpunit\tests\browse-happy.php:21

 2) Tests_Browse_Happy::test_browsehappy_parse_user_agent with data set #35
 ('Mozilla/5.0 (iPad; U; CPU OS ....21.10', 'iPad Safari 4.0.4')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'iPad Safari 4.0.4'
 +'iPad iPad 4.0.4'

 S:\home\wordpress.dev\meta\sites\trunk\api.wordpress.org\public_html\core
 \browse-happy\1.0\tests\phpunit\tests\browse-happy.php:21

 3) Tests_Browse_Happy::test_browsehappy_parse_user_agent with data set #36
 ('Mozilla/5.0 (iPhone; U; CPU i...3.18.5', 'iPhone Safari 5.0.2')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'iPhone Safari 5.0.2'
 +'iPhone iPhone 5.0.2'

 S:\home\wordpress.dev\meta\sites\trunk\api.wordpress.org\public_html\core
 \browse-happy\1.0\tests\phpunit\tests\browse-happy.php:21

 4) Tests_Browse_Happy::test_browsehappy_parse_user_agent with data set #37
 ('Mozilla/5.0 (iPhone; U; CPU l.../419.3', 'iPhone Safari 3.0')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'iPhone Safari 3.0'
 +'iPhone iPhone 3.0'

 S:\home\wordpress.dev\meta\sites\trunk\api.wordpress.org\public_html\core
 \browse-happy\1.0\tests\phpunit\tests\browse-happy.php:21

 5) Tests_Browse_Happy::test_browsehappy_parse_user_agent with data set #46
 ('Mozilla/5.0 (Linux; U; Androi...534.13', 'Android Safari 4.0')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'Android Safari 4.0'
 +'Linux Safari 4.0'

 S:\home\wordpress.dev\meta\sites\trunk\api.wordpress.org\public_html\core
 \browse-happy\1.0\tests\phpunit\tests\browse-happy.php:21

 FAILURES!
 Tests: 94, Assertions: 58, Failures: 5.
 }}}

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2587#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org