[wp-meta] [Making WordPress.org] #2566: Forums: No "Keep a log of this edit" option for replies

[Making WordPress.org]

#2566: Forums: No "Keep a log of this edit" option for replies
----------------------------+-----------------
 Reporter:  SergeyBiryukov  |      Owner:
     Type:  defect          |     Status:  new
 Priority:  normal          |  Milestone:
Component:  Support Forums  |   Keywords:
----------------------------+-----------------
 When editing a topic, there's a "Keep a log of this edit" option that can
 be disabled.

 When editing a reply, the option is not displayed. The code is there, it's
 just [source:sites/trunk/buddypress.org/public_html/wp-content/themes/bb-
 base/style.css?rev=4632&marks=923-926#L923 hidden by bb-base theme
 styles].

 The issue is caused by a markup inconsistency between `form-topic.php` and
 `form-reply.php`:

 In `form-topic.php` the `<legend>` element contains only the Revision
 label:
 {{{
 <legend><?php _e( 'Revision', 'wporg-forums' ); ?></legend>
 <div>
         <input name="bbp_log_topic_edit" id="bbp_log_topic_edit"
 type="checkbox" value="1" <?php bbp_form_topic_log_edit(); ?> />
         <label for="bbp_log_topic_edit"><?php _e( 'Keep a log of this
 edit:', 'wporg-forums' ); ?></label><br />
 </div>
 }}}
 In `form-reply.php`, the `<legend>` element contains the whole input:
 {{{
 <legend>
         <input name="bbp_log_reply_edit" id="bbp_log_reply_edit"
 type="checkbox" value="1" <?php bbp_form_reply_log_edit(); ?> />
         <label for="bbp_log_reply_edit"><?php esc_html_e( 'Keep a log of
 this edit:', 'wporg-forums' ); ?></label><br />
 </legend>
 }}}

 Looks like `form-topic.php` should be updated to use the same markup, see
 [bb5060].

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2566>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org