[wp-meta] [Making WordPress.org] #2850: Introducing a custom taxonomy "groups" for the speakers shortcode
Making WordPress.org
noreply at wordpress.org
Tue Jun 6 22:52:17 UTC 2017
#2850: Introducing a custom taxonomy "groups" for the speakers shortcode
-------------------------------------+---------------------------
Reporter: Kau-Boy | Owner: coreymckrill
Type: enhancement | Status: accepted
Priority: normal | Milestone:
Component: WordCamp Site & Plugins | Resolution:
Keywords: dev-feedback has-patch |
-------------------------------------+---------------------------
Comment (by Kau-Boy):
Thanks for your feedback @coreymckrill!
- I used the same sanitization as you have done for `tracks`
- The `tax_query` was indeed on the wrong place. As my VVV just decided
yesterday, to not start MariaDB anymore, I couldn't test it :(
- I have never added a REST API parameter for a taxonomy and the sponsors
CPT looks a lot more complex. I would be glad if we could work on that
together at the WCEU Contributor Day, but it shouldn't be a blocker for
this ticket, don't you think?
- The term `groups` is generic, but as it's only used as the shortcode
args name, it should not conflict with anything. Or am I missing
something? The rewrite slug for the taxonomy is already `speaker-group`,
so that should be safe.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2850#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list