[wp-meta] [Making WordPress.org] #2849: Improve the sessions list on the speakers bio page
Making WordPress.org
noreply at wordpress.org
Mon Jun 5 20:00:46 UTC 2017
#2849: Improve the sessions list on the speakers bio page
-------------------------------------+---------------------------
Reporter: Kau-Boy | Owner: coreymckrill
Type: enhancement | Status: accepted
Priority: normal | Milestone:
Component: WordCamp Site & Plugins | Resolution:
Keywords: has-patch dev-feedback |
-------------------------------------+---------------------------
Comment (by coreymckrill):
@Kau-Boy @iandunn I'm a little concerned about back compatibility with
this patch, since it will apply to all previous WC sites and it changes
the markup that wraps the speaker session info, in addition to adding more
session info.
Here is an example of the old markup:
{{{
<h2 class="speaker-sessions">Session</h2>
<ul id="speaker-session-names">
<li><a href="http://2014.seattle.wordcamp.dev/session/seo-panel-
discussion/">Making Sense of SEO for WordPress</a></li>
</ul>
}}}
And here is the same session with the new markup suggested in the patch:
{{{
<h2 class="speaker-sessions">Session</h2>
<div id="wcorg-session-807223" class="wcorg-session">
<h3 class="wcorg-session-title"><a
href="http://2014.seattle.wordcamp.dev/session/seo-panel-
discussion/">Making Sense of SEO for WordPress</a></h3>
<div class="wcorg-session-description">This panel discussion will
focus on SEO issues specific to WordPress and, particularly, blogs. In
addition, it will attempt to illuminate the lastest in Google goofiness
and other peculiarities of SEO. It is not a basic tutorial in SEO, but is
still a good choice for beginners.</div>
</div>
}}}
Couldn't we keep the `<ul id="speaker-session-names">` wrapper and add the
additional divs, etc. inside the `<li>` tags? That way we won't risk
broken layout on any sites that have applied layout/styling to the session
lists. Plus, I think keeping the top-level list makes more sense
semantically since speakers can have more than one session.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2849#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list