[wp-meta] [Making WordPress.org] #2934: Coming Soon Page doesn't completely hide WordCamp content
Making WordPress.org
noreply at wordpress.org
Fri Jul 21 18:51:33 UTC 2017
#2934: Coming Soon Page doesn't completely hide WordCamp content
----------------------------------------+---------------------------
Reporter: RMarks | Owner: coreymckrill
Type: defect | Status: accepted
Priority: normal | Milestone:
Component: WordCamp Site & Plugins | Resolution:
Keywords: needs-patch good-first-bug |
----------------------------------------+---------------------------
Comment (by coreymckrill):
@RMarks the patch looks good. The only thing I would recommend, and it's
fairly minor, is that instead of `wp_loaded` you use an action hook that's
a little bit closer to when the `jetpack_enable_open_graph` hook gets
fired (which happens during `wp_head`). The `template_redirect` hook, for
example. That way, it's more likely the routine will only run on requests
that are relevant to its functionality. With `wp_loaded` the routine will
run on nearly all requests, including those for backend WP Admin screens.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2934#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list