[wp-meta] [Making WordPress.org] #2857: News blog on Firefox for android and facebook falls out of content

Making WordPress.org noreply at wordpress.org
Thu Jul 20 20:22:52 UTC 2017


#2857: News blog on Firefox for android and facebook falls out of content
---------------------------+---------------------
 Reporter:  dingo_bastard  |       Owner:
     Type:  defect         |      Status:  closed
 Priority:  high           |   Milestone:
Component:  General        |  Resolution:  fixed
 Keywords:  has-patch      |
---------------------------+---------------------

Comment (by joyously):

 `box-sizing: border-box` affects how padding is rendered. All manual
 adjustments to padding in legacy content would be different if that is
 globally applied. This can break content layouts and make images look
 smaller. Especially when padding percentages are used, you just don't know
 what is in the old content.

 A couple of years ago, I was using a theme for several sites. There was an
 upgrade that applied box-sizing globally. My sites looked strange and I'm
 sure I didn't even look at all the pages. I got the theme author to change
 it to only apply to images or theme-controlled elements. It has to be used
 together with the padding and margins, not independently.

 A few months ago, I helped a theme author debug a problem where the text
 typed into the search box wasn't visible. It was because of the box-
 sizing. The padding used to line up the input with the icon was strange.
 As soon as we removed box-sizing, it was easy to line it up.
 So, there is no knowing what kind of manual adjustments were already made
 to the content being styled. Adding box-sizing globally can be
 problematic.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2857#comment:6>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list