[wp-meta] [Making WordPress.org] #2841: Theme Directory - Feature filter has a min-height

Making WordPress.org noreply at wordpress.org
Tue Jul 11 01:17:22 UTC 2017

#2841: Theme Directory - Feature filter has a min-height
 Reporter:  joyously         |       Owner:
     Type:  defect           |      Status:  new
 Priority:  normal           |   Milestone:
Component:  Theme Directory  |  Resolution:
 Keywords:                   |

Comment (by SergeyBiryukov):

 Fixed height was originally added in [1034] and switched to `min-height`
 in [1543]. The commit included a hardcoded height of `710px` and some JS
 code to increase the height for all filters if one of them gets higher due
 to longer strings.

 However, [3622] has updated the list of features, `710px` is no longer
 enough, and now that JS code always runs.

 I think we could probably remove the fixed height. The page appears to be
 designed to mimic the theme install screen from WordPress core, which
 doesn't have fixed height for the filters.

Ticket URL: <https://meta.trac.wordpress.org/ticket/2841#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list