[wp-meta] [Making WordPress.org] #2143: Internationalize WordCamp Dashboard Widgets plugin
Making WordPress.org
noreply at wordpress.org
Fri Jan 13 04:45:04 UTC 2017
#2143: Internationalize WordCamp Dashboard Widgets plugin
--------------------------------------+----------------------
Reporter: iandunn | Owner: iandunn
Type: defect | Status: closed
Priority: low | Milestone:
Component: WordCamp Site & Plugins | Resolution: fixed
Keywords: good-first-bug has-patch |
--------------------------------------+----------------------
Comment (by coreymckrill):
@chandrapatel Thanks, and nice work!
A couple of suggestions for your next patch:
* For PHP files, your indents should be with
[https://make.wordpress.org/core/handbook/best-practices/coding-
standards/php/#indentation tab characters rather than spaces].
* Keep the patch focused on the ticket issue. This patch had a couple of
miscellaneous changes to comment punctuation and additional commas on
array items. These aren't ''bad'', but they distract from the important
changes in the patch, so it's best to include them separately.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2143#comment:7>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list