[wp-meta] [Making WordPress.org] #2043: Last Post ignores post status

[Making WordPress.org]

#2043: Last Post ignores post status
----------------------------+------------------
 Reporter:  Clorith         |       Owner:
     Type:  defect          |      Status:  new
 Priority:  normal          |   Milestone:
Component:  Support Forums  |  Resolution:
 Keywords:  needs-patch     |
----------------------------+------------------

Comment (by SergeyBiryukov):

 To summarize, the issue is that some topic metadata (`_bbp_last_reply_id`,
 `_bbp_last_active_id`, `_bbp_last_active_time`, `_bbp_reply_count`) is
 missing or inaccurate since `bbp_update_topic_walker()` was disabled for
 performance reasons in [3898].

 Looks like there are three potential options:
 1. Use available bbPress hooks to work around the issues caused by
 inaccurate metadata.
 2. Find a way to update the necessary metadata without using
 `bbp_update_topic_walker()`.
 3. Investigate and resolve `bbp_update_topic_walker()` performance issues
 mentioned in [3898].

 The correct long-term solution is probably option 2 or 3.

 [attachment:2043.2.patch] implements option 1, just to get the ball
 rolling:
 * For non-moderators, if the topic has hidden replies, the last reply
 link, last activity time, last post author, and pagination links all
 properly account for that.
 * For moderators, those links have `view=all` appended to them, so when
 you open the link, hidden replies are displayed as expected.

 This adds a few SQL queries on the front end, hopefully less expensive
 than `bbp_update_topic_walker()`. I only tested the patch on a small
 install though.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2043#comment:8>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org