[wp-meta] [Making WordPress.org] #3077: Add missing singular placeholder in comments.php wordpress.tv
Making WordPress.org
noreply at wordpress.org
Tue Aug 29 11:49:46 UTC 2017
#3077: Add missing singular placeholder in comments.php wordpress.tv
--------------------------+------------------
Reporter: afzalmultani | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: WordPress.tv | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by SergeyBiryukov):
* keywords: => has-patch
Comment:
For a bit more context, the suggested pattern is recommended for languages
that use the singular form for other numbers (e.g. 21, 31 and so on), see
https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals.
It's now implemented in Twenty Sixteen and Twenty Seventeen, and should be
added to older bundled themes as well in #WP39660.
[attachment:3077.diff] looks good, the only issue is that
`get_comments_number()` returns a string and should not be strictly
compared to an integer.
[attachment:3077.2.diff] fixes that and removes unrelated formatting
changes.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3077#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list