[wp-meta] [Making WordPress.org] #2769: Header menu is not displayed on Rosetta sites without a custom menu
Making WordPress.org
noreply at wordpress.org
Fri Apr 21 00:37:40 UTC 2017
#2769: Header menu is not displayed on Rosetta sites without a custom menu
-------------------------------------------+-----------------------
Reporter: SergeyBiryukov | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: International Sites (Rosetta) | Keywords: has-patch
-------------------------------------------+-----------------------
Background: comment:2:ticket:2618
On Rosetta sites that don't have a custom nav menu, the header menu falls
back to `wp_page_menu()`, but the items are not displayed due to current
styles in `wp4.css`. See an example on
https://sah.wordpress.org/plugins/akismet/.
It's because `wp_page_menu()` has a bit different markup than
`wp_nav_menu()` (it doesn't have an option to omit the container, see
#WP33974):
{{{
<div id="wporg-header-menu" class="menu">
<ul>
...
</ul>
</div>
}}}
vs.
{{{
<ul id="wporg-header-menu" class="menu">
...
</ul>
}}}
The attached patch fixes the issue, see the screenshots. This doesn't
explain why the Blog page is marked as current, but at least makes the
header menu visible.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2769>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list