[wp-meta] [Making WordPress.org] #2668: Replies to internal notes have the wrong comment type

Making WordPress.org noreply at wordpress.org
Thu Apr 6 23:01:27 UTC 2017


#2668: Replies to internal notes have the wrong comment type
------------------------------+------------------------------------
 Reporter:  ocean90           |       Owner:
     Type:  defect            |      Status:  new
 Priority:  high              |   Milestone:  Plugin Directory v3.0
Component:  Plugin Directory  |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------------------------

Comment (by SergeyBiryukov):

 > To make it work on edit.php and edit-comments.php we could add a check
 to `preprocess_comment` which sets `comment_type` if
 `$commentdata['comment_parent']` is an ID for an internal note.

 I think we could just inherit comment type from parent comment in
 `::save_custom_comment()`, see [attachment:2668.2.patch] (also includes
 the patch from #2667).

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2668#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list