[wp-meta] [Making WordPress.org] #2668: Replies to internal notes have the wrong comment type

Making WordPress.org noreply at wordpress.org
Tue Apr 4 06:42:29 UTC 2017


#2668: Replies to internal notes have the wrong comment type
------------------------------+------------------------------------
 Reporter:  ocean90           |       Owner:
     Type:  defect            |      Status:  new
 Priority:  normal            |   Milestone:  Plugin Directory v3.0
Component:  Plugin Directory  |  Resolution:
 Keywords:  needs-patch       |
------------------------------+------------------------------------
Changes (by arvindsinghu):

 * priority:  high => normal


Comment:

 Replying to [ticket:2668 ocean90]:
 >
 `WordPressdotorg\Plugin_Directory\Admin\Customizations::save_custom_comment()`
 (or `wp_ajax_replyto_comment()` sets the type if `$_POST['comment_type']`
 is set but `wp_comment_reply()` doesn't define a `comment_type` field.
 >
 > To make it work on edit.php and edit-comments.php we could add a check
 to `preprocess_comment` which sets `comment_type` if
 `$commentdata['comment_parent']` is an ID for an internal note.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2668#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list