[wp-meta] [Making WordPress.org] #2035: Improve i18n in Ratings_Compat

[Making WordPress.org]

#2035: Improve i18n in Ratings_Compat
------------------------------+--------------------------
 Reporter:  SergeyBiryukov    |       Owner:  coffee2code
     Type:  defect            |      Status:  reopened
 Priority:  normal            |   Milestone:
Component:  Support Forums    |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+--------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:3 coffee2code]:
 > In order to maintain the alignment of the per-rating bars, the labels
 that precede them must be of equal width, thus the text must contain the
 same amount of characters. There are options for making the text truly
 translatable according to number, but there are enough considerations to
 warrant a separate ticket.

 Thank you for a detailed reply! I think this was previously resolved in
 #1165 for the (old) plugin directory, no? At least on
 https://ru.wordpress.org/plugins/wordpress-seo/, the `%d star, %d stars`
 string properly supports plural forums and the alignment still looks good.

 [attachment:meta-2035.2.patch] fixes a few more issues with one string
 missed in my previous patch:

 * Remove unnecessary HTML from the translatable string
 * Add missing text domain and translator comment
 * Add `number_format_i18n()`

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2035#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org