[wp-meta] [Making WordPress.org] #1112: Site Cloner: Scale to support hundreds of sites

[Making WordPress.org]

#1112: Site Cloner: Scale to support hundreds of sites
--------------------------+-----------------------
 Reporter:  iandunn       |       Owner:  iandunn
     Type:  enhancement   |      Status:  accepted
 Priority:  normal        |   Milestone:
Component:  wordcamp.org  |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------

Comment (by iandunn):

 Thanks Michael, that looks great :)

 A couple minor things:

 1) The whitespace changes add
 [https://meta.trac.wordpress.org/attachment/ticket/1112/1112-site-cloner-
 scaling.diff a lot of noise to the diff], though, making it harder to
 review. I usually like to do those in a separate commit, after the main
 changes have been merged.

 Sometimes IDEs do those automatically, so you may need to adjust your
 settings to only modify lines that you're already changing.

 The easiest way I've found to revert those specific changes in SVN, while
 leaving the others in tact, is to check out a second copy of the folder,
 then use a visual diff tool like DeltaWalker to copy the whitespace-only
 lines back to the working copy. If you're using Git, I think `git checkout
 -p` is the simplest way.

 2) The code looks like it's heading in a good direction, but `site-
 option.php` is missing from the diff, so I can't test it. Can you upload
 another diff with the whitespace changes reverted, and `site-option.php`
 included?

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1112#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org