[wp-meta] [Making WordPress.org] #1646: Pre-commit hooks on plugin repo block code beyond PHP 5.4
Making WordPress.org
noreply at wordpress.org
Thu Mar 24 21:14:54 UTC 2016
#1646: Pre-commit hooks on plugin repo block code beyond PHP 5.4
------------------------------+-----------------
Reporter: leewillis77 | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: Plugin Directory | Keywords:
------------------------------+-----------------
The plugin repo blocks the committing of any code that uses syntax
specific to modern versions of PHP (anecdotally > 5.4, although I haven't
checked to confirm).
I understand that this is an attempt to avoid WSOD, but the hooks trigger
failures even if the plugin checks for, and deals gracefully with the
issue - it looks like all files are linted even if they wouldn't be
included in practice.
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
PHP Parse error: syntax error, unexpected '.', expecting ',' or ';' in -
on line 38
This seems (see twitter threads below) to be a known issue, but I couldn't
find a ticket to follow, so logging this so there is some transparency
about the efforts to resolve it.
https://twitter.com/soulseekah/status/702227207767330816
https://twitter.com/leewillis77/status/707694122677698560
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1646>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list