[wp-meta] [Making WordPress.org] #1691: Internationalisation
Making WordPress.org
noreply at wordpress.org
Tue Jun 7 21:33:44 UTC 2016
#1691: Internationalisation
------------------------------+---------------------------------------
Reporter: dd32 | Owner: ocean90
Type: task | Status: reviewing
Priority: high | Milestone: Plugin Directory v3 - M5
Component: Plugin Directory | Resolution:
Keywords: |
------------------------------+---------------------------------------
Comment (by ocean90):
Replying to [comment:12 tellyworth]:
> Search translation will work easily if translated content is available
in postmeta, for example as `fr_title` and `fr_content`.
Wish I would have known this sooner. :) Post meta is definitely easier
since we don't have to care about the relationships.
If we want to go live without a persistent storage I'm fine with that
since I can't spend much time on this at the moment. But I still think
that the whole readme translation process needs an overhaul long-term
(like parsing the readme.txt instead of HTML).
[attachment:class-plugin-i18n.diff] looks good at a first glance. Beside
some code styling issues:
* Shouldn't filter moved to the `if ( 'en_US' != get_locale() ) {}`
condition?
* What's the purpose of `wp_get_locale()`? Looks like it's just
`get_locale()`. (Note: `WP_LANG` doesn't exist.)
* Let's replace all `translate_` table prefixes with
`GLOTPRESS_TABLE_PREFIX`
And while looking at the code I remembered that we already have a [
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
/wp-content/plugins/glotpress-translate-bridge/glotpress-translate-
bridge.php GlotPress Translate Bridge] which we're using for themes... I
think there are some opportunities to combine both.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1691#comment:13>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list