[wp-meta] [Making WordPress.org] #1722: Generate a plugins.svn authentication file
Making WordPress.org
noreply at wordpress.org
Thu Jun 2 11:26:05 UTC 2016
#1722: Generate a plugins.svn authentication file
-----------------------------------+---------------------------------------
Reporter: dd32 | Owner: pento
Type: task | Status: assigned
Priority: high | Milestone: Plugin Directory v3 - M5
Component: Plugin Directory | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+---------------------------------------
Comment (by dd32):
@pento agreed on all points there.
`exit()` is weird, but logical in this case - technically I think there's
a "proper" way to have an alternate output format, but it'd be overkill
here.
Only downside is that post-rest-api actions potentially won't be called,
so no caching middleman etc - we don't care about that for this endpoint
though.
You could use `PLUGINS_TABLE_PREFIX . 'svn_access'` if you wanted (which
is what we use in the other functions that interact with the table) but
'eh. It would probably be best for us to rename the table to
`wporg_367_svn_access` after launch to ensure that the table never goes
astray, so we'd update it then anyway.
only nitpick would be:
{{{
this->svn_access = array();
$this->svn_access_table = 'plugin_2_svn_access';
}}}
Why define those there, when they can just be defined inline?
{{{
protected $svn_access = array();
protected $svn_access_table = 'plugin_2_svn_access';
}}}
And in general I also have been using `protected` over `private` so that
the methods/properties are available to subclasses (if one was to ever
exist for some reason).
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1722#comment:7>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list