[wp-meta] [Making WordPress.org] #334: Improve the Coming Soon design for new WordCamp sites
Making WordPress.org
noreply at wordpress.org
Mon Aug 22 16:34:00 UTC 2016
#334: Improve the Coming Soon design for new WordCamp sites
-------------------------------------+-----------------------
Reporter: iandunn | Owner: iandunn
Type: enhancement | Status: reopened
Priority: normal | Milestone:
Component: WordCamp Site & Plugins | Resolution:
Keywords: has-screenshots |
-------------------------------------+-----------------------
Comment (by iandunn):
In [changeset:"3835"]:
{{{
#!CommitTicketReference repository="" revision="3835"
WordCamp Coming Soon Page: Fix broken menu link.
This bug didn't exist in the original patch, but was introduced during the
review phase, because I didn't connect the dots between
`register_settings_pages()` and `get_customizer_section_url()`, and
thought it'd be better to use an absolute URL.
The bug didn't show up during local testing because of differences between
the nginx configuration on my sandbox and the config on production, and I
failed to test production after deploying.
This commit reverts it back to a relative URL so that it will work again,
and also moves it inside `register_settings_pages()` to avoid confusing it
with a complete URL that would be safe to use in other contexts.
See #334
Props ryelle
}}}
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/334#comment:29>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list