[wp-meta] [Making WordPress.org] #1903: Hardcoded strings in WordCamp.org plugin camptix-attendance

Making WordPress.org noreply at wordpress.org
Wed Aug 17 16:15:56 UTC 2016


#1903: Hardcoded strings in WordCamp.org plugin camptix-attendance
-------------------------------------+------------------------
 Reporter:  kossmann                 |       Owner:  kovshenin
     Type:  defect                   |      Status:  assigned
 Priority:  normal                   |   Milestone:
Component:  WordCamp Site & Plugins  |  Resolution:
 Keywords:  has-patch                |
-------------------------------------+------------------------
Changes (by iandunn):

 * owner:   => kovshenin
 * status:  new => assigned


Comment:

 Hi Daniel, thanks for the patch!

 This looks pretty good to me. The only minor things I'd change would be to
 use the `wordcamporg` text domain instead of `camptix`, and to always use
 the escaping translate functions (like `esc_html__`).

 CampTix has it's own text domain because it's distributed in the
 WordPress.org repository, but the add-ons in the Meta repository should
 all use `wordcamporg`, so that they'll be included in our single GlotPress
 project.

 Not everyone agrees with this, but personally I consider it a best
 practice to always use the escaping translate functions, to avoid any
 situations where malicious HTML is inserted into localized strings.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1903#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list