[wp-meta] [Making WordPress.org] #334: Improve the Coming Soon design for new WordCamp sites

Making WordPress.org noreply at wordpress.org
Tue Aug 2 15:10:28 UTC 2016


#334: Improve the Coming Soon design for new WordCamp sites
-------------------------------------+-----------------------
 Reporter:  iandunn                  |       Owner:  iandunn
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:
Component:  WordCamp Site & Plugins  |  Resolution:
 Keywords:  has-screenshots          |
-------------------------------------+-----------------------
Changes (by iandunn):

 * keywords:  ui-feedback has-screenshots => has-screenshots


Comment:

 I skimmed the diff and it looks really good, thanks! I'll try to fit in
 some time this week to merge it.

 The only minor thing I'd change would be to `esc_attr()` each time a value
 is `echo`'d, rather than using `array_walk()`. That way, it's completely
 obvious that the value has been escaped, rather than having to look higher
 up the code to check. It also makes it possible for static analysis tools
 like PHP Code Sniffer to know it's escaped, reducing the number of false-
 positives.

 For the old Settings page, what do you think about getting rid of it
 completely, and just making it a link to `wp-
 admin/customize.php?autofocus[section]=wccsp_live_preview` ? Would users
 be confused by that, or would they understand that it's moved? If it
 wouldn't confuse people, it seems better to me, since it's fewer clicks
 and less code.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/334#comment:17>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list