[wp-meta] [Making WordPress.org] #859: Warn WordCamp organizers when their site is in Coming Soon mode
Making WordPress.org
noreply at wordpress.org
Mon Apr 11 18:11:44 UTC 2016
#859: Warn WordCamp organizers when their site is in Coming Soon mode
----------------------------------------+-----------------------
Reporter: iandunn | Owner: iandunn
Type: enhancement | Status: accepted
Priority: normal | Milestone:
Component: wordcamp.org | Resolution:
Keywords: good-first-bug needs-patch |
----------------------------------------+-----------------------
Comment (by iandunn):
Great, thanks :)
I think the only major change left is for the capabilities. Removing
capabilities from individual roles isn't the best approach, because it has
to be done to each role, and there might be roles generated by other
plugins in addition to the ones that Core creates.
Capabilities are one of the least understood aspects of WP development,
but typically it's best to use the `user_hap_cap` filter to modify
primitive capabilities, and `map_meta_cap` to modify meta capabilities.
Minor changes:
* Use the reference to `$wp_admin_bar` that gets passed by the
admin_bar_menu action handler, rather than accessing the global directly
* Check out WordPress' coding standards for PHP; there are several things
related to indentation, spacing, and Yoda conditionals that need to be
tweaked.
* `block_new_post_coming_soon()` should have PHPDoc
* Variable names should be clear, descriptive and self-documenting; e.g.,
`$message` instead of `$msg`
* Replace `sample-text-domain`
* [https://developer.wordpress.org/plugins/internationalization/how-to-
internationalize-your-plugin/#variables Use placeholders for variables in
translated strings]
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/859#comment:9>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list