[wp-meta] [Making WordPress.org] #1303: Browse Happy API detection bugs

[Making WordPress.org]

#1303: Browse Happy API detection bugs
------------------------+-----------------------------
  Reporter:  chriscct7  |      Owner:
      Type:  defect     |     Status:  new
  Priority:  normal     |  Component:  browsehappy.com
Resolution:             |   Keywords:  needs-patch
------------------------+-----------------------------

Old description:

> Migrated from: https://core.trac.wordpress.org/ticket/18281 per
> https://core.trac.wordpress.org/ticket/18281#comment:15
>
> {{{
> A few bugs we've noticed with the Browse Happy API so far:
> Mobile versions need to be labeled as such. Specifically, Mobile Safari,
> Opera Mini, and the Galaxy tablet, I believe. This should mean that the
> browser doesn't match with our list of five.
> For IE, we need to be looking at the Trident version numbers. Problem is,
> IE9 might be using a compatibility UA, which means it would get
> identified as IE7. Trident/5.0 is IE9, Trident/4.0 is using IE8.
> I think the architecture of the API code needs some love. It served its
> purpose, but it's a bit inflexible for expansion. (See the Kindle hack
> and such.)
> I'm going to open source this code onto http://code.svn.wordpress.org. It
> would be fantastic if some people can contribute to it and make it the
> best possible.
>
> }}}

New description:

 Migrated from: https://core.trac.wordpress.org/ticket/18281 per
 https://core.trac.wordpress.org/ticket/18281#comment:15

 A few bugs we've noticed with the Browse Happy API so far:

 1. Mobile versions need to be labeled as such. Specifically, Mobile
 Safari, Opera Mini, and the Galaxy tablet, I believe. This should mean
 that the browser doesn't match with our list of five.

 2. For IE, we need to be looking at the Trident version numbers. Problem
 is, IE9 might be using a compatibility UA, which means it would get
 identified as IE7. Trident/5.0 is IE9, Trident/4.0 is using IE8.

 I think the architecture of the API code needs some love. It served its
 purpose, but it's a bit inflexible for expansion. (See the Kindle hack and
 such.)

 I'm going to open source this code onto http://code.svn.wordpress.org. It
 would be fantastic if some people can contribute to it and make it the
 best possible.

--

Comment (by netweb):

 ''Restored original ticket formatting for improved readability.''

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1303#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org